Commit 32c2d33e authored by Hao Xu's avatar Hao Xu Committed by Jens Axboe
Browse files

io_uring: fix off-by-one in BUILD_BUG_ON check of __REQ_F_LAST_BIT 



Build check of __REQ_F_LAST_BIT should be larger than, not equal or larger
than. It's perfectly valid to have __REQ_F_LAST_BIT be 32, as that means
that the last valid bit is 31 which does fit in the type.

Signed-off-by: default avatarHao Xu <haoxu@linux.alibaba.com>
Link: https://lore.kernel.org/r/20210907032243.114190-1-haoxu@linux.alibaba.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2ae2eb9d

fs/io_uring.c

+1 −1
Original line number Diff line number Diff line
@@ -10863,7 +10863,7 @@ static int __init io_uring_init(void) 
	BUILD_BUG_ON(SQE_VALID_FLAGS >= (1 << 8));



	BUILD_BUG_ON(ARRAY_SIZE(io_op_defs) != IORING_OP_LAST);

	BUILD_BUG_ON(__REQ_F_LAST_BIT >= 8 * sizeof(int));

	BUILD_BUG_ON(__REQ_F_LAST_BIT > 8 * sizeof(int));



	req_cachep = KMEM_CACHE(io_kiocb, SLAB_HWCACHE_ALIGN | SLAB_PANIC |

				SLAB_ACCOUNT);