Commit 32b378a9 authored by Fabrice Gasnier's avatar Fabrice Gasnier Committed by Vinod Koul
Browse files

phy: stm32: fix error return in stm32_usbphyc_phy_init 



Error code is overridden, in case the PLL doesn't lock. So, the USB
initialization can continue. This leads to a platform freeze.
This can be avoided by returning proper error code to avoid USB probe
freezing the platform. It also displays proper errors in log.

Fixes: 5b1af712 ("phy: stm32: rework PLL Lock detection")
Signed-off-by: default avatarFabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/20220713133953.595134-1-fabrice.gasnier@foss.st.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 08fd292f

drivers/phy/st/phy-stm32-usbphyc.c

+3 −1
Original line number Diff line number Diff line
@@ -358,7 +358,9 @@ static int stm32_usbphyc_phy_init(struct phy *phy) 
	return 0;



pll_disable:

	return stm32_usbphyc_pll_disable(usbphyc);

	stm32_usbphyc_pll_disable(usbphyc);



	return ret;

}



static int stm32_usbphyc_phy_exit(struct phy *phy)