Commit 32aeba1f authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

tg3: Remove unused PHY_BRCM flags 



The tg3 driver tried to communicate towards the PHY driver whether it
wanted RGMII in-band signaling enabled or disabled however there is
nothing that looks at those flags in drivers/net/phy/broadcom.c so this
does do not anything.

Suggested-by: default avatarVladimir Oltean <olteanv@gmail.com>
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2928de97

drivers/net/ethernet/broadcom/tg3.c

+0 −6
Original line number Diff line number Diff line
@@ -1580,12 +1580,6 @@ static int tg3_mdio_init(struct tg3 *tp) 
				     PHY_BRCM_RX_REFCLK_UNUSED |

				     PHY_BRCM_DIS_TXCRXC_NOENRGY |

				     PHY_BRCM_AUTO_PWRDWN_ENABLE;

		if (tg3_flag(tp, RGMII_INBAND_DISABLE))

			phydev->dev_flags |= PHY_BRCM_STD_IBND_DISABLE;

		if (tg3_flag(tp, RGMII_EXT_IBND_RX_EN))

			phydev->dev_flags |= PHY_BRCM_EXT_IBND_RX_ENABLE;

		if (tg3_flag(tp, RGMII_EXT_IBND_TX_EN))

			phydev->dev_flags |= PHY_BRCM_EXT_IBND_TX_ENABLE;

		fallthrough;

	case PHY_ID_RTL8211C:

		phydev->interface = PHY_INTERFACE_MODE_RGMII;

include/linux/brcmphy.h

+3 −6
Original line number Diff line number Diff line
@@ -63,12 +63,9 @@ 


#define PHY_BRCM_AUTO_PWRDWN_ENABLE	0x00000001

#define PHY_BRCM_RX_REFCLK_UNUSED	0x00000002

#define PHY_BRCM_STD_IBND_DISABLE	0x00000004

#define PHY_BRCM_EXT_IBND_RX_ENABLE	0x00000008

#define PHY_BRCM_EXT_IBND_TX_ENABLE	0x00000010

#define PHY_BRCM_CLEAR_RGMII_MODE	0x00000020

#define PHY_BRCM_DIS_TXCRXC_NOENRGY	0x00000040

#define PHY_BRCM_EN_MASTER_MODE		0x00000080

#define PHY_BRCM_CLEAR_RGMII_MODE	0x00000004

#define PHY_BRCM_DIS_TXCRXC_NOENRGY	0x00000008

#define PHY_BRCM_EN_MASTER_MODE		0x00000010



/* Broadcom BCM7xxx specific workarounds */

#define PHY_BRCM_7XXX_REV(x)		(((x) >> 8) & 0xff)