Commit 32a47817 authored by Randy Dunlap's avatar Randy Dunlap Committed by Tejun Heo
Browse files

cgroup/cpuset: fix a few kernel-doc warnings & coding style 



Fix kernel-doc notation warnings:

kernel/cgroup/cpuset.c:1309: warning: Excess function parameter 'cpuset' description in 'update_parent_subparts_cpumask'
kernel/cgroup/cpuset.c:3909: warning: expecting prototype for cpuset_mem_spread_node(). Prototype was for cpuset_spread_node() instead

Also drop a blank line before EXPORT_SYMBOL_GPL() to be consistent
with kernel coding style.

Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: cgroups@vger.kernel.org
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 980660ca

kernel/cgroup/cpuset.c

+8 −5
Original line number Diff line number Diff line
@@ -1267,7 +1267,7 @@ static int update_flag(cpuset_flagbits_t bit, struct cpuset *cs, 
		       int turning_on);

/**

 * update_parent_subparts_cpumask - update subparts_cpus mask of parent cpuset

 * @cpuset:  The cpuset that requests change in partition root state

 * @cs:      The cpuset that requests change in partition root state

 * @cmd:     Partition root state change command

 * @newmask: Optional new cpumask for partcmd_update

 * @tmp:     Temporary addmask and delmask
@@ -3877,8 +3877,7 @@ bool __cpuset_node_allowed(int node, gfp_t gfp_mask) 
}



/**

 * cpuset_mem_spread_node() - On which node to begin search for a file page

 * cpuset_slab_spread_node() - On which node to begin search for a slab page

 * cpuset_spread_node() - On which node to begin search for a page

 *

 * If a task is marked PF_SPREAD_PAGE or PF_SPREAD_SLAB (as for

 * tasks in a cpuset with is_spread_page or is_spread_slab set),
@@ -3902,12 +3901,14 @@ bool __cpuset_node_allowed(int node, gfp_t gfp_mask) 
 * is passed an offline node, it will fall back to the local node.

 * See kmem_cache_alloc_node().

 */



static int cpuset_spread_node(int *rotor)

{

	return *rotor = next_node_in(*rotor, current->mems_allowed);

}



/**

 * cpuset_mem_spread_node() - On which node to begin search for a file page

 */

int cpuset_mem_spread_node(void)

{

	if (current->cpuset_mem_spread_rotor == NUMA_NO_NODE)
@@ -3917,6 +3918,9 @@ int cpuset_mem_spread_node(void) 
	return cpuset_spread_node(&current->cpuset_mem_spread_rotor);

}



/**

 * cpuset_slab_spread_node() - On which node to begin search for a slab page

 */

int cpuset_slab_spread_node(void)

{

	if (current->cpuset_slab_spread_rotor == NUMA_NO_NODE)
@@ -3925,7 +3929,6 @@ int cpuset_slab_spread_node(void) 


	return cpuset_spread_node(&current->cpuset_slab_spread_rotor);

}



EXPORT_SYMBOL_GPL(cpuset_mem_spread_node);



/**