Commit 32a1bda4 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Michael Ellerman
Browse files

powerpc/opal: use default_groups in kobj_type 



There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field.  Move the powerpc opal dump and elog sysfs code to use
default_groups field which has been the preferred way since aa30f47c
("kobject: Add support for default attribute groups to kobj_type") so
that we can soon get rid of the obsolete default_attrs field.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220104161318.1306023-1-gregkh@linuxfoundation.org
parent 2bdf3f9e

arch/powerpc/platforms/powernv/opal-dump.c

+2 −1
Original line number Diff line number Diff line
@@ -208,11 +208,12 @@ static struct attribute *dump_default_attrs[] = { 
	&ack_attribute.attr,

	NULL,

};

ATTRIBUTE_GROUPS(dump_default);



static struct kobj_type dump_ktype = {

	.sysfs_ops = &dump_sysfs_ops,

	.release = &dump_release,

	.default_attrs = dump_default_attrs,

	.default_groups = dump_default_groups,

};



static int64_t dump_read_info(uint32_t *dump_id, uint32_t *dump_size, uint32_t *dump_type)

arch/powerpc/platforms/powernv/opal-elog.c

+2 −1
Original line number Diff line number Diff line
@@ -144,11 +144,12 @@ static struct attribute *elog_default_attrs[] = { 
	&ack_attribute.attr,

	NULL,

};

ATTRIBUTE_GROUPS(elog_default);



static struct kobj_type elog_ktype = {

	.sysfs_ops = &elog_sysfs_ops,

	.release = &elog_release,

	.default_attrs = elog_default_attrs,

	.default_groups = elog_default_groups,

};



/* Maximum size of a single log on FSP is 16KB */