Commit 32818c07 authored by Cong Wang's avatar Cong Wang Committed by David S. Miller
Browse files

geneve: fix an uninitialized value in geneve_changelink() 



geneve_nl2info() sets 'df' conditionally, so we have to
initialize it by copying the value from existing geneve
device in geneve_changelink().

Fixes: 56c09de3 ("geneve: allow changing DF behavior after creation")
Reported-by: default avatar <syzbot+7ebc2e088af5e4c0c9fa@syzkaller.appspotmail.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c75d1d52

drivers/net/geneve.c

+1 −1
Original line number Diff line number Diff line
@@ -1615,11 +1615,11 @@ static int geneve_changelink(struct net_device *dev, struct nlattr *tb[], 
			     struct netlink_ext_ack *extack)

{

	struct geneve_dev *geneve = netdev_priv(dev);

	enum ifla_geneve_df df = geneve->df;

	struct geneve_sock *gs4, *gs6;

	struct ip_tunnel_info info;

	bool metadata;

	bool use_udp6_rx_checksums;

	enum ifla_geneve_df df;

	bool ttl_inherit;

	int err;