Commit 32663c78 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'trace-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace 

Pull tracing updates from Steven Rostedt:

 - The biggest news in that the tracing ring buffer can now time events
   that interrupted other ring buffer events.

   Before this change, if an interrupt came in while recording another
   event, and that interrupt also had an event, those events would all
   have the same time stamp as the event it interrupted.

   Now, with the new design, those events will have a unique time stamp
   and rightfully display the time for those events that were recorded
   while interrupting another event.

 - Bootconfig how has an "override" operator that lets the users have a
   default config, but then add options to override the default.

 - A fix was made to properly filter function graph tracing to the
   ftrace PIDs. This came in at the end of the -rc cycle, and needs to
   be backported.

 - Several clean ups, performance updates, and minor fixes as well.

* tag 'trace-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: (39 commits)
  tracing: Add trace_array_init_printk() to initialize instance trace_printk() buffers
  kprobes: Fix compiler warning for !CONFIG_KPROBES_ON_FTRACE
  tracing: Use trace_sched_process_free() instead of exit() for pid tracing
  bootconfig: Fix to find the initargs correctly
  Documentation: bootconfig: Add bootconfig override operator
  tools/bootconfig: Add testcases for value override operator
  lib/bootconfig: Add override operator support
  kprobes: Remove show_registers() function prototype
  tracing/uprobe: Remove dead code in trace_uprobe_register()
  kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler
  ftrace: Fix ftrace_trace_task return value
  tracepoint: Use __used attribute definitions from compiler_attributes.h
  tracepoint: Mark __tracepoint_string's __used
  trace : Have tracing buffer info use kvzalloc instead of kzalloc
  tracing: Remove outdated comment in stack handling
  ftrace: Do not let direct or IPMODIFY ftrace_ops be added to module and set trampolines
  ftrace: Setup correct FTRACE_FL_REGS flags for module
  tracing/hwlat: Honor the tracing_cpumask
  tracing/hwlat: Drop the duplicate assignment in start_kthread()
  tracing: Save one trace_event->type by using __TRACE_LAST_TYPE
  ...
parents 7b9de977 38ce2a9e

Documentation/admin-guide/bootconfig.rst

+11 −0
Original line number Diff line number Diff line
@@ -71,6 +71,16 @@ For example,:: 
 foo = bar, baz

 foo = qux  # !ERROR! we can not re-define same key



If you want to update the value, you must use the override operator

``:=`` explicitly. For example::



 foo = bar, baz

 foo := qux



then, the ``qux`` is assigned to ``foo`` key. This is useful for

overriding the default value by adding (partial) custom bootconfigs

without parsing the default bootconfig.



If you want to append the value to existing key as an array member,

you can use ``+=`` operator. For example::
@@ -84,6 +94,7 @@ For example, following config is NOT allowed.:: 


 foo = value1

 foo.bar = value2 # !ERROR! subkey "bar" and value "value1" can NOT co-exist

 foo.bar := value2 # !ERROR! even with the override operator, this is NOT allowed.





Comments

arch/x86/kernel/ftrace.c

+11 −3
Original line number Diff line number Diff line
@@ -286,6 +286,7 @@ extern void ftrace_regs_caller_ret(void); 
extern void ftrace_caller_end(void);

extern void ftrace_caller_op_ptr(void);

extern void ftrace_regs_caller_op_ptr(void);

extern void ftrace_regs_caller_jmp(void);



/* movq function_trace_op(%rip), %rdx */

/* 0x48 0x8b 0x15 <offset-to-ftrace_trace_op (4 bytes)> */
@@ -316,6 +317,7 @@ create_trampoline(struct ftrace_ops *ops, unsigned int *tramp_size) 
	unsigned long end_offset;

	unsigned long op_offset;

	unsigned long call_offset;

	unsigned long jmp_offset;

	unsigned long offset;

	unsigned long npages;

	unsigned long size;
@@ -333,11 +335,13 @@ create_trampoline(struct ftrace_ops *ops, unsigned int *tramp_size) 
		end_offset = (unsigned long)ftrace_regs_caller_end;

		op_offset = (unsigned long)ftrace_regs_caller_op_ptr;

		call_offset = (unsigned long)ftrace_regs_call;

		jmp_offset = (unsigned long)ftrace_regs_caller_jmp;

	} else {

		start_offset = (unsigned long)ftrace_caller;

		end_offset = (unsigned long)ftrace_caller_end;

		op_offset = (unsigned long)ftrace_caller_op_ptr;

		call_offset = (unsigned long)ftrace_call;

		jmp_offset = 0;

	}



	size = end_offset - start_offset;
@@ -367,10 +371,14 @@ create_trampoline(struct ftrace_ops *ops, unsigned int *tramp_size) 
	if (WARN_ON(ret < 0))

		goto fail;



	/* No need to test direct calls on created trampolines */

	if (ops->flags & FTRACE_OPS_FL_SAVE_REGS) {

		ip = trampoline + (ftrace_regs_caller_ret - ftrace_regs_caller);

		ret = copy_from_kernel_nofault(ip, (void *)retq, RET_SIZE);

		if (WARN_ON(ret < 0))

		/* NOP the jnz 1f; but make sure it's a 2 byte jnz */

		ip = trampoline + (jmp_offset - start_offset);

		if (WARN_ON(*(char *)ip != 0x75))

			goto fail;

		ret = copy_from_kernel_nofault(ip, ideal_nops[2], 2);

		if (ret < 0)

			goto fail;

	}

arch/x86/kernel/ftrace_64.S

+14 −15
Original line number Diff line number Diff line
@@ -241,22 +241,10 @@ SYM_INNER_LABEL(ftrace_regs_call, SYM_L_GLOBAL) 
	 */

	movq ORIG_RAX(%rsp), %rax

	testq	%rax, %rax

	jz	1f

SYM_INNER_LABEL(ftrace_regs_caller_jmp, SYM_L_GLOBAL)

	jnz	1f



	/* Swap the flags with orig_rax */

	movq MCOUNT_REG_SIZE(%rsp), %rdi

	movq %rdi, MCOUNT_REG_SIZE-8(%rsp)

	movq %rax, MCOUNT_REG_SIZE(%rsp)



	restore_mcount_regs 8

	/* Restore flags */

	popfq



SYM_INNER_LABEL(ftrace_regs_caller_ret, SYM_L_GLOBAL);

	UNWIND_HINT_RET_OFFSET

	jmp	ftrace_epilogue



1:	restore_mcount_regs

	restore_mcount_regs

	/* Restore flags */

	popfq
@@ -269,6 +257,17 @@ SYM_INNER_LABEL(ftrace_regs_caller_ret, SYM_L_GLOBAL); 
SYM_INNER_LABEL(ftrace_regs_caller_end, SYM_L_GLOBAL)

	jmp ftrace_epilogue



	/* Swap the flags with orig_rax */

1:	movq MCOUNT_REG_SIZE(%rsp), %rdi

	movq %rdi, MCOUNT_REG_SIZE-8(%rsp)

	movq %rax, MCOUNT_REG_SIZE(%rsp)



	restore_mcount_regs 8

	/* Restore flags */

	popfq

	UNWIND_HINT_RET_OFFSET

	jmp	ftrace_epilogue



SYM_FUNC_END(ftrace_regs_caller)

include/linux/kprobes.h

+0 −1
Original line number Diff line number Diff line
@@ -227,7 +227,6 @@ extern int arch_prepare_kprobe(struct kprobe *p); 
extern void arch_arm_kprobe(struct kprobe *p);

extern void arch_disarm_kprobe(struct kprobe *p);

extern int arch_init_kprobes(void);

extern void show_registers(struct pt_regs *regs);

extern void kprobes_inc_nmissed_count(struct kprobe *p);

extern bool arch_within_kprobe_blacklist(unsigned long addr);

extern int arch_populate_kprobe_blacklist(void);

include/linux/ring_buffer.h

+1 −0
Original line number Diff line number Diff line
@@ -143,6 +143,7 @@ bool ring_buffer_iter_dropped(struct ring_buffer_iter *iter); 
unsigned long ring_buffer_size(struct trace_buffer *buffer, int cpu);



void ring_buffer_reset_cpu(struct trace_buffer *buffer, int cpu);

void ring_buffer_reset_online_cpus(struct trace_buffer *buffer);

void ring_buffer_reset(struct trace_buffer *buffer);



#ifdef CONFIG_RING_BUFFER_ALLOW_SWAP