Commit 32621eb6 authored by Po-Hao Huang's avatar Po-Hao Huang Committed by Kalle Valo
Browse files

rtw88: fix null vif pointer when hw_scan fails 



Add this check to avoid crash by dereferencing a null pointer. When hwscan
fails due to no memory or dma failure, the scan flag in ieee80211_local is
cleared. So mac80211 determine that it's not hw_scan then calls
sw_scan_complete() with null vif, which is also freed during the fail.

Signed-off-by: default avatarPo-Hao Huang <phhuang@realtek.com>
Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220520081523.45987-1-pkshih@realtek.com
parent 425671f0

drivers/net/wireless/realtek/rtw88/main.c

+4 −1
Original line number Diff line number Diff line
@@ -1383,9 +1383,12 @@ void rtw_core_scan_start(struct rtw_dev *rtwdev, struct rtw_vif *rtwvif, 
void rtw_core_scan_complete(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,

			    bool hw_scan)

{

	struct rtw_vif *rtwvif = (struct rtw_vif *)vif->drv_priv;

	struct rtw_vif *rtwvif = vif ? (struct rtw_vif *)vif->drv_priv : NULL;

	u32 config = 0;



	if (!rtwvif)

		return;



	clear_bit(RTW_FLAG_SCANNING, rtwdev->flags);

	clear_bit(RTW_FLAG_DIG_DISABLE, rtwdev->flags);