Commit 32452a3e authored by Joseph Ravichandran's avatar Joseph Ravichandran Committed by Jens Axboe
Browse files

io_uring: fix uninitialized field in rw io_kiocb 



io_rw_init_file does not initialize kiocb->private, so when iocb_bio_iopoll
reads kiocb->private it can contain uninitialized data.

Fixes: 3e08773c ("block: switch polling to be bio based")
Signed-off-by: default avatarJoseph Ravichandran <jravi@mit.edu>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5a1e99b6

fs/io_uring.c

+1 −0
Original line number Diff line number Diff line
@@ -3783,6 +3783,7 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode) 
		if (!(kiocb->ki_flags & IOCB_DIRECT) || !file->f_op->iopoll)

			return -EOPNOTSUPP;



		kiocb->private = NULL;

		kiocb->ki_flags |= IOCB_HIPRI | IOCB_ALLOC_CACHE;

		kiocb->ki_complete = io_complete_rw_iopoll;

		req->iopoll_completed = 0;