Commit 3228cec2 authored by Zheng Wang's avatar Zheng Wang Committed by Mauro Carvalho Chehab
Browse files

media: rkvdec: fix use after free bug in rkvdec_remove 



In rkvdec_probe, rkvdec->watchdog_work is bound with
rkvdec_watchdog_func. Then rkvdec_vp9_run may
be called to start the work.

If we remove the module which will call rkvdec_remove
 to make cleanup, there may be a unfinished work.
 The possible sequence is as follows, which will
 cause a typical UAF bug.

Fix it by canceling the work before cleanup in rkvdec_remove.

CPU0                  CPU1

                    |rkvdec_watchdog_func
rkvdec_remove       |
 rkvdec_v4l2_cleanup|
  v4l2_m2m_release  |
    kfree(m2m_dev); |
                    |
                    | v4l2_m2m_get_curr_priv
                    |   m2m_dev->curr_ctx //use

Fixes: cd33c830 ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 50d0a7ae

drivers/staging/media/rkvdec/rkvdec.c

+2 −0
Original line number Diff line number Diff line
@@ -1066,6 +1066,8 @@ static int rkvdec_remove(struct platform_device *pdev) 
{

	struct rkvdec_dev *rkvdec = platform_get_drvdata(pdev);



	cancel_delayed_work_sync(&rkvdec->watchdog_work);



	rkvdec_v4l2_cleanup(rkvdec);

	pm_runtime_disable(&pdev->dev);

	pm_runtime_dont_use_autosuspend(&pdev->dev);