Unverified Commit 31f6d96d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

spi: pxa2xx: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-56-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 224d9437

drivers/spi/spi-pxa2xx.c

+2 −4
Original line number Diff line number Diff line
@@ -1659,7 +1659,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) 
	return status;

}



static int pxa2xx_spi_remove(struct platform_device *pdev)

static void pxa2xx_spi_remove(struct platform_device *pdev)

{

	struct driver_data *drv_data = platform_get_drvdata(pdev);

	struct ssp_device *ssp = drv_data->ssp;
@@ -1684,8 +1684,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev) 


	/* Release SSP */

	pxa_ssp_free(ssp);



	return 0;

}



static int pxa2xx_spi_suspend(struct device *dev)
@@ -1770,7 +1768,7 @@ static struct platform_driver driver = { 
		.of_match_table = of_match_ptr(pxa2xx_spi_of_match),

	},

	.probe = pxa2xx_spi_probe,

	.remove = pxa2xx_spi_remove,

	.remove_new = pxa2xx_spi_remove,

};



static int __init pxa2xx_spi_init(void)