Commit 31e07aa3 authored by Wang Hai's avatar Wang Hai Committed by Kalle Valo
Browse files

qtnfmac: fix error return code in qtnf_pcie_probe() 



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: b7da53cd ("qtnfmac_pcie: use single PCIe driver for all platforms")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201114123347.29632-1-wanghai38@huawei.com
parent 0409d504

drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c

+3 −3
Original line number Diff line number Diff line
@@ -299,19 +299,19 @@ static int qtnf_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	sysctl_bar = qtnf_map_bar(pdev, QTN_SYSCTL_BAR);

	if (IS_ERR(sysctl_bar)) {

		pr_err("failed to map BAR%u\n", QTN_SYSCTL_BAR);

		return ret;

		return PTR_ERR(sysctl_bar);

	}



	dmareg_bar = qtnf_map_bar(pdev, QTN_DMA_BAR);

	if (IS_ERR(dmareg_bar)) {

		pr_err("failed to map BAR%u\n", QTN_DMA_BAR);

		return ret;

		return PTR_ERR(dmareg_bar);

	}



	epmem_bar = qtnf_map_bar(pdev, QTN_SHMEM_BAR);

	if (IS_ERR(epmem_bar)) {

		pr_err("failed to map BAR%u\n", QTN_SHMEM_BAR);

		return ret;

		return PTR_ERR(epmem_bar);

	}



	chipid = qtnf_chip_id_get(sysctl_bar);