Unverified Commit 31bb7bd9 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: core: Only call sof_ops_free() on remove if the probe was successful 



All the fail paths during probe will free up the ops, on remove we should
only free it if the probe was successful.

Fixes: bc433fd7 ("ASoC: SOF: Add ops_free")
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20230915124015.19637-1-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e0f96246

sound/soc/sof/core.c

+1 −2
Original line number Diff line number Diff line
@@ -486,9 +486,8 @@ int snd_sof_device_remove(struct device *dev) 
		snd_sof_ipc_free(sdev);

		snd_sof_free_debug(sdev);

		snd_sof_remove(sdev);

	}



		sof_ops_free(sdev);

	}



	/* release firmware */

	snd_sof_fw_unload(sdev);