Commit 31ac3bce authored by Dimitris Michailidis's avatar Dimitris Michailidis Committed by Jakub Kicinski
Browse files

net/fungible: Fix reference to __udivdi3 on 32b builds 



32b builds with CONFIG_PHYS_ADDR_T_64BIT=y, such as i386 PAE,
raise a linker error due to a 64b division:

ld: drivers/net/ethernet/fungible/funcore/fun_dev.o: in function
`fun_dev_enable':
(.text+0xe1a): undefined reference to `__udivdi3'

The divisor in the offendinng expression is a power of 2. Change it to
use an explicit right shift.

Fixes: e1ffcc66 ("net/fungible: Add service module for Fungible drivers")
Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarDimitris Michailidis <dmichail@fungible.com>
Link: https://lore.kernel.org/r/20220401232411.313881-1-dmichail@fungible.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 37391cc8

drivers/net/ethernet/fungible/funcore/fun_dev.c

+2 −2
Original line number Diff line number Diff line
@@ -586,8 +586,8 @@ static int fun_get_dev_limits(struct fun_dev *fdev) 
	/* Calculate the max QID based on SQ/CQ/doorbell counts.

	 * SQ/CQ doorbells alternate.

	 */

	num_dbs = (pci_resource_len(pdev, 0) - NVME_REG_DBS) /

		  (fdev->db_stride * 4);

	num_dbs = (pci_resource_len(pdev, 0) - NVME_REG_DBS) >>

		  (2 + NVME_CAP_STRIDE(fdev->cap_reg));

	fdev->max_qid = min3(cq_count, sq_count, num_dbs / 2) - 1;

	fdev->kern_end_qid = fdev->max_qid + 1;

	return 0;