Commit 31834aaa authored by Yang Yingliang's avatar Yang Yingliang Committed by Rafael J. Wysocki
Browse files

ACPI: pfr_update: Fix return value check in pfru_write() 



In case of error, memremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: 0db89fa2 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Acked-by: default avatarChen Yu <yu.c.chen@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 53e85588

drivers/acpi/pfr_update.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -460,8 +460,8 @@ static ssize_t pfru_write(struct file *file, const char __user *buf, 
	/* map the communication buffer */

	/* map the communication buffer */

	phy_addr = (phys_addr_t)((buf_info.addr_hi << 32) | buf_info.addr_lo);

	phy_addr = (phys_addr_t)((buf_info.addr_hi << 32) | buf_info.addr_lo);

	buf_ptr = memremap(phy_addr, buf_info.buf_size, MEMREMAP_WB);

	buf_ptr = memremap(phy_addr, buf_info.buf_size, MEMREMAP_WB);

	if (IS_ERR(buf_ptr))

	if (!buf_ptr)

		return PTR_ERR(buf_ptr);

		return -ENOMEM;





	if (!copy_from_iter_full(buf_ptr, len, &iter)) {

	if (!copy_from_iter_full(buf_ptr, len, &iter)) {

		ret = -EINVAL;

		ret = -EINVAL;