Commit 3168010d authored by Nícolas F. R. A. Prado's avatar Nícolas F. R. A. Prado Committed by Joerg Roedel
Browse files

iommu/mediatek: Log with dev_err_probe when failing to parse dts 



mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs
have probed yet, so use dev_err_probe() to avoid logging as an error in
that case. Also drop the return value from the message since it's
already printed by dev_err_probe(), and add the missing newline at the
end.

Signed-off-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220712214427.544860-1-nfraprado@collabora.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 301c3ca1

drivers/iommu/mtk_iommu.c

+1 −1
Original line number Diff line number Diff line
@@ -1216,7 +1216,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) 
	if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {

		ret = mtk_iommu_mm_dts_parse(dev, &match, data);

		if (ret) {

			dev_err(dev, "mm dts parse fail(%d).", ret);

			dev_err_probe(dev, ret, "mm dts parse fail\n");

			goto out_runtime_disable;

		}

	} else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA)) {