Commit 3153724f authored by Tong Zhang's avatar Tong Zhang Committed by David S. Miller
Browse files

atm: uPD98402: fix incorrect allocation 



dev->dev_data is set in zatm.c, calling zatm_start() will overwrite this
dev->dev_data in uPD98402_start() and a subsequent PRIV(dev)->lock
(i.e dev->phy_data->lock) will result in a null-ptr-dereference.

I believe this is a typo and what it actually want to do is to allocate
phy_data instead of dev_data.

Signed-off-by: default avatarTong Zhang <ztong0001@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1019d792

drivers/atm/uPD98402.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ static void uPD98402_int(struct atm_dev *dev) 
static int uPD98402_start(struct atm_dev *dev)

{

	DPRINTK("phy_start\n");

	if (!(dev->dev_data = kmalloc(sizeof(struct uPD98402_priv),GFP_KERNEL)))

	if (!(dev->phy_data = kmalloc(sizeof(struct uPD98402_priv),GFP_KERNEL)))

		return -ENOMEM;

	spin_lock_init(&PRIV(dev)->lock);

	memset(&PRIV(dev)->sonet_stats,0,sizeof(struct k_sonet_stats));