Commit 315241d2 authored by Daniele Ceraolo Spurio's avatar Daniele Ceraolo Spurio
Browse files

drm/i915/huc: drop intel_huc_is_authenticated 



The function name is confusing, because it doesn't check the actual auth
status in HW but the SW status. Given that there is only one user (the
huc_auth function itself), just get rid of it and use the FW status
checker directly.

Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: default avatarAlan Previn <alan.previn.teres.alexis@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220504204816.2082588-2-daniele.ceraolospurio@intel.com
parent a5c89f7c

drivers/gpu/drm/i915/gt/uc/intel_huc.c

+1 −1
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ int intel_huc_auth(struct intel_huc *huc) 
	struct intel_guc *guc = &gt->uc.guc;

	int ret;



	GEM_BUG_ON(intel_huc_is_authenticated(huc));

	GEM_BUG_ON(intel_uc_fw_is_running(&huc->fw));



	if (!intel_uc_fw_is_loaded(&huc->fw))

		return -ENOEXEC;

drivers/gpu/drm/i915/gt/uc/intel_huc.h

+0 −5
Original line number Diff line number Diff line
@@ -50,11 +50,6 @@ static inline bool intel_huc_is_used(struct intel_huc *huc) 
	return intel_uc_fw_is_available(&huc->fw);

}



static inline bool intel_huc_is_authenticated(struct intel_huc *huc)

{

	return intel_uc_fw_is_running(&huc->fw);

}



void intel_huc_load_status(struct intel_huc *huc, struct drm_printer *p);



#endif