Commit 3145095f authored by Guillaume Ranquet's avatar Guillaume Ranquet Committed by Chun-Kuang Hu
Browse files

drm/mediatek: dpi: Implement a swap_input toggle in SoC config 



The hardware design of dp_intf does not support input swap, so we add
a bit of flexibility to support SoCs without swap_input support.
We also add a warning message if the hardware is not supported and it
needs to swap input.

Signed-off-by: default avatarGuillaume Ranquet <granquet@baylibre.com>
Signed-off-by: default avatarBo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarRex-BC Chen <rex-bc.chen@mediatek.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20220701035845.16458-8-rex-bc.chen@mediatek.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent cf060519

drivers/gpu/drm/mediatek/mtk_dpi.c

+8 −1
Original line number Diff line number Diff line
@@ -121,6 +121,7 @@ struct mtk_dpi_yc_limit { 
 * @output_fmts: Array of supported output formats.

 * @num_output_fmts: Quantity of supported output formats.

 * @is_ck_de_pol: Support CK/DE polarity.

 * @swap_input_support: Support input swap function.

 */

struct mtk_dpi_conf {

	unsigned int (*cal_factor)(int clock);
@@ -130,6 +131,7 @@ struct mtk_dpi_conf { 
	const u32 *output_fmts;

	u32 num_output_fmts;

	bool is_ck_de_pol;

	bool swap_input_support;

};



static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -393,6 +395,7 @@ static void mtk_dpi_config_color_format(struct mtk_dpi *dpi, 
	/* only support RGB888 */

	mtk_dpi_config_yuv422_enable(dpi, false);

	mtk_dpi_config_csc_enable(dpi, false);

	if (dpi->conf->swap_input_support)

		mtk_dpi_config_swap_input(dpi, false);

	mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);

}
@@ -804,6 +807,7 @@ static const struct mtk_dpi_conf mt8173_conf = { 
	.output_fmts = mt8173_output_fmts,

	.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),

	.is_ck_de_pol = true,

	.swap_input_support = true,

};



static const struct mtk_dpi_conf mt2701_conf = {
@@ -814,6 +818,7 @@ static const struct mtk_dpi_conf mt2701_conf = { 
	.output_fmts = mt8173_output_fmts,

	.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),

	.is_ck_de_pol = true,

	.swap_input_support = true,

};



static const struct mtk_dpi_conf mt8183_conf = {
@@ -823,6 +828,7 @@ static const struct mtk_dpi_conf mt8183_conf = { 
	.output_fmts = mt8183_output_fmts,

	.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),

	.is_ck_de_pol = true,

	.swap_input_support = true,

};



static const struct mtk_dpi_conf mt8192_conf = {
@@ -832,6 +838,7 @@ static const struct mtk_dpi_conf mt8192_conf = { 
	.output_fmts = mt8183_output_fmts,

	.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),

	.is_ck_de_pol = true,

	.swap_input_support = true,

};



static int mtk_dpi_probe(struct platform_device *pdev)