Commit 311eca64 authored by Simon Ser's avatar Simon Ser
Browse files

drm/atomic: log when CRTC_ID prop value is invalid 



Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221019143736.267324-4-contact@emersion.fr
parent e51259d7

drivers/gpu/drm/drm_atomic_uapi.c

+10 −2
Original line number Diff line number Diff line
@@ -539,8 +539,12 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, 
	} else if (property == config->prop_crtc_id) {

		struct drm_crtc *crtc = drm_crtc_find(dev, file_priv, val);



		if (val && !crtc)

		if (val && !crtc) {

			drm_dbg_atomic(dev,

				       "[PROP:%d:%s] cannot find CRTC with ID %llu\n",

				       property->base.id, property->name, val);

			return -EACCES;

		}

		return drm_atomic_set_crtc_for_plane(state, crtc);

	} else if (property == config->prop_crtc_x) {

		state->crtc_x = U642I64(val);
@@ -695,8 +699,12 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector, 
	if (property == config->prop_crtc_id) {

		struct drm_crtc *crtc = drm_crtc_find(dev, file_priv, val);



		if (val && !crtc)

		if (val && !crtc) {

			drm_dbg_atomic(dev,

				       "[PROP:%d:%s] cannot find CRTC with ID %llu\n",

				       property->base.id, property->name, val);

			return -EACCES;

		}

		return drm_atomic_set_crtc_for_connector(state, crtc);

	} else if (property == config->dpms_property) {

		/* setting DPMS property requires special handling, which