Commit 310cd4c2 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Linus Walleij
Browse files

pinctrl: microchip-sgpio: check return value of devm_kasprintf() 



devm_kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 7e5ea974 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230615105333.585304-3-claudiu.beznea@microchip.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9063777c

drivers/pinctrl/pinctrl-microchip-sgpio.c

+3 −0
Original line number Diff line number Diff line
@@ -816,6 +816,9 @@ static int microchip_sgpio_register_bank(struct device *dev, 
	pctl_desc->name = devm_kasprintf(dev, GFP_KERNEL, "%s-%sput",

					 dev_name(dev),

					 bank->is_input ? "in" : "out");

	if (!pctl_desc->name)

		return -ENOMEM;



	pctl_desc->pctlops = &sgpio_pctl_ops;

	pctl_desc->pmxops = &sgpio_pmx_ops;

	pctl_desc->confops = &sgpio_confops;