Commit 31038364 authored by Magnus Karlsson's avatar Magnus Karlsson Committed by Daniel Borkmann
Browse files

xsk: Fix clang build error in __xp_alloc 



Fix a build error with clang in __xp_alloc():

  [...]
  net/xdp/xsk_buff_pool.c:465:15: error: variable 'xskb' is uninitialized
  when used here [-Werror,-Wuninitialized]
                          xp_release(xskb);
                                     ^~~~

This is correctly detected by clang, but not gcc. In fact, the xp_release()
statement should not be there at all in the refactored code, just remove it.

Fixes: 94033cd8 ("xsk: Optimize for aligned case")
Reported-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarMagnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Link: https://lore.kernel.org/bpf/20210929061403.8587-1-magnus.karlsson@gmail.com
parent 38261f36

net/xdp/xsk_buff_pool.c

+0 −1
Original line number Diff line number Diff line
@@ -462,7 +462,6 @@ static struct xdp_buff_xsk *__xp_alloc(struct xsk_buff_pool *pool) 
	for (;;) {

		if (!xskq_cons_peek_addr_unchecked(pool->fq, &addr)) {

			pool->fq->queue_empty_descs++;

			xp_release(xskb);

			return NULL;

		}