Commit 30ca44eb authored by Miquel Raynal's avatar Miquel Raynal Committed by Stefan Schmidt
Browse files

net: mac802154: Create an offloaded transmission error helper 



So far there is only a helper for successful transmissions, which led
device drivers to implement their own handling in case of
error. Unfortunately, we really need all the drivers to give the hand
back to the core once they are done in order to be able to build a
proper synchronous API. So let's create a _xmit_error() helper and take
this opportunity to fill the new device-global field storing Tx
statuses.

Suggested-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Acked-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20220407100903.1695973-5-miquel.raynal@bootlin.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
parent 337e2f86

include/net/mac802154.h

+10 −0
Original line number Diff line number Diff line
@@ -498,4 +498,14 @@ void ieee802154_stop_queue(struct ieee802154_hw *hw); 
void ieee802154_xmit_complete(struct ieee802154_hw *hw, struct sk_buff *skb,

			      bool ifs_handling);



/**

 * ieee802154_xmit_error - offloaded frame transmission failed

 *

 * @hw: pointer as obtained from ieee802154_alloc_hw().

 * @skb: buffer for transmission

 * @reason: error code

 */

void ieee802154_xmit_error(struct ieee802154_hw *hw, struct sk_buff *skb,

			   int reason);



#endif /* NET_MAC802154_H */

net/mac802154/util.c

+11 −0
Original line number Diff line number Diff line
@@ -91,6 +91,17 @@ void ieee802154_xmit_complete(struct ieee802154_hw *hw, struct sk_buff *skb, 
}

EXPORT_SYMBOL(ieee802154_xmit_complete);



void ieee802154_xmit_error(struct ieee802154_hw *hw, struct sk_buff *skb,

			   int reason)

{

	struct ieee802154_local *local = hw_to_local(hw);



	local->tx_result = reason;

	ieee802154_wake_queue(hw);

	dev_kfree_skb_any(skb);

}

EXPORT_SYMBOL(ieee802154_xmit_error);



void ieee802154_stop_device(struct ieee802154_local *local)

{

	flush_workqueue(local->workqueue);