Commit 30ae8017 authored by Po-Hsu Lin's avatar Po-Hsu Lin Committed by David S. Miller
Browse files

selftests/net: improve descriptions for XFAIL cases in psock_snd.sh 



Before changing this it's a bit confusing to read test output:
  raw csum_off with bad offset (fails)
  ./psock_snd: write: Invalid argument

Change "fails" in the test case description to "expected to fail", so
that the test output can be more understandable.

Signed-off-by: default avatarPo-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6bd860ac

tools/testing/selftests/net/psock_snd.sh

+8 −8
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ echo "raw vnet hdr" 
echo "raw csum_off"

./in_netns.sh ./psock_snd -v -c



echo "raw csum_off with bad offset (fails)"

echo "raw csum_off with bad offset (expected to fail)"

(! ./in_netns.sh ./psock_snd -v -c -C)
@@ -57,7 +57,7 @@ echo "raw min size" 
echo "raw mtu size"

./in_netns.sh ./psock_snd -l "${mss}"



echo "raw mtu size + 1 (fails)"

echo "raw mtu size + 1 (expected to fail)"

(! ./in_netns.sh ./psock_snd -l "${mss_exceeds}")



# fails due to ARPHRD_ETHER check in packet_extra_vlan_len_allowed
@@ -65,19 +65,19 @@ echo "raw mtu size + 1 (fails)" 
# echo "raw vlan mtu size"

# ./in_netns.sh ./psock_snd -V -l "${mss}"



echo "raw vlan mtu size + 1 (fails)"

echo "raw vlan mtu size + 1 (expected to fail)"

(! ./in_netns.sh ./psock_snd -V -l "${mss_exceeds}")



echo "dgram mtu size"

./in_netns.sh ./psock_snd -d -l "${mss}"



echo "dgram mtu size + 1 (fails)"

echo "dgram mtu size + 1 (expected to fail)"

(! ./in_netns.sh ./psock_snd -d -l "${mss_exceeds}")



echo "raw truncate hlen (fails: does not arrive)"

echo "raw truncate hlen (expected to fail: does not arrive)"

(! ./in_netns.sh ./psock_snd -t "$((${vnet_hlen} + ${eth_hlen}))")



echo "raw truncate hlen - 1 (fails: EINVAL)"

echo "raw truncate hlen - 1 (expected to fail: EINVAL)"

(! ./in_netns.sh ./psock_snd -t "$((${vnet_hlen} + ${eth_hlen} - 1))")
@@ -86,13 +86,13 @@ echo "raw truncate hlen - 1 (fails: EINVAL)" 
echo "raw gso min size"

./in_netns.sh ./psock_snd -v -c -g -l "${mss_exceeds}"



echo "raw gso min size - 1 (fails)"

echo "raw gso min size - 1 (expected to fail)"

(! ./in_netns.sh ./psock_snd -v -c -g -l "${mss}")



echo "raw gso max size"

./in_netns.sh ./psock_snd -v -c -g -l "${max_mss}"



echo "raw gso max size + 1 (fails)"

echo "raw gso max size + 1 (expected to fail)"

(! ./in_netns.sh ./psock_snd -v -c -g -l "${max_mss_exceeds}")



echo "OK. All tests passed"