Commit 30a51400 authored by Peng Liu's avatar Peng Liu Committed by Andrew Morton
Browse files

mm: use for_each_online_node and node_online instead of open coding

Use more generic functions to deal with issues related to online nodes. 
The changes will make the code simplified.

Link: https://lkml.kernel.org/r/20220429030218.644635-1-liupeng256@huawei.com


Signed-off-by: default avatarPeng Liu <liupeng256@huawei.com>
Suggested-by: default avatarDavidlohr Bueso <dave@stgolabs.net>
Suggested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarMuchun Song <songmuchun@bytedance.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f81f6e4b
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -261,7 +261,7 @@ static int __init uncached_init(void)
{
	int nid;

	for_each_node_state(nid, N_ONLINE) {
	for_each_online_node(nid) {
		uncached_pools[nid].pool = gen_pool_create(PAGE_SHIFT, nid);
		mutex_init(&uncached_pools[nid].add_chunk_mutex);
	}
+2 −2
Original line number Diff line number Diff line
@@ -6971,7 +6971,7 @@ void __init hugetlb_cma_reserve(int order)
		if (hugetlb_cma_size_in_node[nid] == 0)
			continue;

		if (!node_state(nid, N_ONLINE)) {
		if (!node_online(nid)) {
			pr_warn("hugetlb_cma: invalid node %d specified\n", nid);
			hugetlb_cma_size -= hugetlb_cma_size_in_node[nid];
			hugetlb_cma_size_in_node[nid] = 0;
@@ -7010,7 +7010,7 @@ void __init hugetlb_cma_reserve(int order)
	}

	reserved = 0;
	for_each_node_state(nid, N_ONLINE) {
	for_each_online_node(nid) {
		int res;
		char name[CMA_MAX_NAME];

+1 −1
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ static int __meminit online_page_ext(unsigned long start_pfn,
		 * online__pages(), and start_pfn should exist.
		 */
		nid = pfn_to_nid(start_pfn);
		VM_BUG_ON(!node_state(nid, N_ONLINE));
		VM_BUG_ON(!node_online(nid));
	}

	for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION)