Commit 3099d2e6 authored by Aya Levin's avatar Aya Levin Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix memory leak on updating vport counters 



When updating statistics driver queries the vport's counters. On fail,
add error path releasing the allocated buffer avoiding memory leak.

Fixes: 64b68e36 ("net/mlx5: Refactor and expand rep vport stat group")
Signed-off-by: default avatarAya Levin <ayal@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent c09502d5

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

+2 −1
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(vport_rep) 
	if (err) {

		netdev_warn(priv->netdev, "vport %d error %d reading stats\n",

			    rep->vport, err);

		return;

		goto out;

	}



	#define MLX5_GET_CTR(p, x) \
@@ -241,6 +241,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(vport_rep) 
	rep_stats->tx_vport_rdma_multicast_bytes =

		MLX5_GET_CTR(out, received_ib_multicast.octets);



out:

	kvfree(out);

}