Commit 30248fef authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: Make cpufreq_update_policy() void 



The return value of cpufreq_update_policy() is never used, so make
it void.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent bca5f557

drivers/cpufreq/cpufreq.c

+7 −14
Original line number Diff line number Diff line
@@ -2257,21 +2257,18 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, 
 *	Useful for policy notifiers which have different necessities

 *	at different times.

 */

int cpufreq_update_policy(unsigned int cpu)

void cpufreq_update_policy(unsigned int cpu)

{

	struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);

	struct cpufreq_policy new_policy;

	int ret;



	if (!policy)

		return -ENODEV;

		return;



	down_write(&policy->rwsem);



	if (policy_is_inactive(policy)) {

		ret = -ENODEV;

	if (policy_is_inactive(policy))

		goto unlock;

	}



	pr_debug("updating policy for CPU %u\n", cpu);

	memcpy(&new_policy, policy, sizeof(*policy));
@@ -2283,24 +2280,20 @@ int cpufreq_update_policy(unsigned int cpu) 
	 * -> ask driver for current freq and notify governors about a change

	 */

	if (cpufreq_driver->get && !cpufreq_driver->setpolicy) {

		if (cpufreq_suspended) {

			ret = -EAGAIN;

		if (cpufreq_suspended)

			goto unlock;

		}



		new_policy.cur = cpufreq_update_current_freq(policy);

		if (WARN_ON(!new_policy.cur)) {

			ret = -EIO;

		if (WARN_ON(!new_policy.cur))

			goto unlock;

	}

	}



	ret = cpufreq_set_policy(policy, &new_policy);

	cpufreq_set_policy(policy, &new_policy);



unlock:

	up_write(&policy->rwsem);



	cpufreq_cpu_put(policy);

	return ret;

}

EXPORT_SYMBOL(cpufreq_update_policy);

include/linux/cpufreq.h

+1 −1
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ void disable_cpufreq(void); 


u64 get_cpu_idle_time(unsigned int cpu, u64 *wall, int io_busy);

int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu);

int cpufreq_update_policy(unsigned int cpu);

void cpufreq_update_policy(unsigned int cpu);

bool have_governor_per_policy(void);

struct kobject *get_governor_parent_kobj(struct cpufreq_policy *policy);

void cpufreq_enable_fast_switch(struct cpufreq_policy *policy);