Commit 3008d20f authored by Matthias Schiffer's avatar Matthias Schiffer Committed by Guenter Roeck
Browse files

hwmon: (pwm-fan) Explicitly switch off fan power when setting pwm1_enable to 0 



When pwm1_enable is changed from 1 to 0 while pwm1 == 0, the regulator
is not switched off as expected. The reason is that when the fan is
already off, ctx->enabled is false, so pwm_fan_power_off() will be a
no-op.

Handle this case explicitly in pwm_fan_update_enable() by calling
pwm_fan_switch_power() directly.

Fixes: b99152d4 ("hwmon: (pwm-fan) Switch regulator dynamically")
Signed-off-by: default avatarMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Link: https://lore.kernel.org/r/20221013135951.4902-1-matthias.schiffer@ew.tq-group.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent b6291023

drivers/hwmon/pwm-fan.c

+4 −1
Original line number Diff line number Diff line
@@ -257,7 +257,10 @@ static int pwm_fan_update_enable(struct pwm_fan_ctx *ctx, long val) 


	if (val == 0) {

		/* Disable pwm-fan unconditionally */

		if (ctx->enabled)

			ret = __set_pwm(ctx, 0);

		else

			ret = pwm_fan_switch_power(ctx, false);

		if (ret)

			ctx->enable_mode = old_val;

		pwm_fan_update_state(ctx, 0);