Commit 300065f9 authored May 24, 2022 by Benjamin Gaignard Committed by Mauro Carvalho Chehab Jun 20, 2022

media: Hantro: Correct G2 init qp field



Documentation said that g2 init_qp field use bits 24 to 30 of
the 8th register.
Change the field mask to be able to set 7 bits and not only 6 of them.

Conformance test INITQP_B_Main10_Sony_1 decoding is OK with this
patch.

Fixes: cb5dd5a0 ("media: hantro: Introduce G2/HEVC decoder")
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

parent 8b0f690d

drivers/staging/media/hantro/hantro_g2_regs.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -107,7 +107,7 @@

		#define g2_start_code_e G2_DEC_REG(10, 31, 0x1)
		#define g2_init_qp_old G2_DEC_REG(10, 25, 0x3f)
		#define g2_init_qp G2_DEC_REG(10, 24, 0x3f)
		#define g2_init_qp G2_DEC_REG(10, 24, 0x7f)
		#define g2_num_tile_cols_old G2_DEC_REG(10, 20, 0x1f)
		#define g2_num_tile_cols G2_DEC_REG(10, 19, 0x1f)
		#define g2_num_tile_rows_old G2_DEC_REG(10, 15, 0x1f)