Commit 2fe34d29 authored by Kyoungho Koo's avatar Kyoungho Koo Committed by Theodore Ts'o
Browse files

ext4: remove unused parameter of ext4_generic_delete_entry function 



The ext4_generic_delete_entry function does not use the parameter
handle, so it can be removed.

Signed-off-by: default avatarKyoungho Koo <rnrudgh@gmail.com>
Reviewed-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Link: https://lore.kernel.org/r/20200810080701.GA14160@koo-Z370-HD3


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent e0d438c7

fs/ext4/ext4.h

+1 −2
Original line number Diff line number Diff line
@@ -2802,8 +2802,7 @@ extern int ext4_search_dir(struct buffer_head *bh, 
			   struct ext4_filename *fname,

			   unsigned int offset,

			   struct ext4_dir_entry_2 **res_dir);

extern int ext4_generic_delete_entry(handle_t *handle,

				     struct inode *dir,

extern int ext4_generic_delete_entry(struct inode *dir,

				     struct ext4_dir_entry_2 *de_del,

				     struct buffer_head *bh,

				     void *entry_buf,

fs/ext4/inline.c

+1 −1
Original line number Diff line number Diff line
@@ -1706,7 +1706,7 @@ int ext4_delete_inline_entry(handle_t *handle, 
	if (err)

		goto out;



	err = ext4_generic_delete_entry(handle, dir, de_del, bh,

	err = ext4_generic_delete_entry(dir, de_del, bh,

					inline_start, inline_size, 0);

	if (err)

		goto out;

fs/ext4/namei.c

+2 −4
Original line number Diff line number Diff line
@@ -2465,8 +2465,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname, 
 * ext4_generic_delete_entry deletes a directory entry by merging it

 * with the previous entry

 */

int ext4_generic_delete_entry(handle_t *handle,

			      struct inode *dir,

int ext4_generic_delete_entry(struct inode *dir,

			      struct ext4_dir_entry_2 *de_del,

			      struct buffer_head *bh,

			      void *entry_buf,
@@ -2527,8 +2526,7 @@ static int ext4_delete_entry(handle_t *handle, 
	if (unlikely(err))

		goto out;



	err = ext4_generic_delete_entry(handle, dir, de_del,

					bh, bh->b_data,

	err = ext4_generic_delete_entry(dir, de_del, bh, bh->b_data,

					dir->i_sb->s_blocksize, csum_size);

	if (err)

		goto out;