Unverified Commit 2fe08216 authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown
Browse files

ASoC: SOF: Fix potential NULL pointer dereference 



Cleanup path for sof_prepare_widgets_in_path() should check if unprepare
callback exists before calling it, instead it checks if it does not
exist. Fix the check.

Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220602135757.3335351-1-amadeuszx.slawinski@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 07551992

sound/soc/sof/sof-audio.c

+1 −1
Original line number Diff line number Diff line
@@ -318,7 +318,7 @@ sof_prepare_widgets_in_path(struct snd_sof_dev *sdev, struct snd_soc_dapm_widget 
			p->walking = false;

			if (ret < 0) {

				/* unprepare the source widget */

				if (!widget_ops[widget->id].ipc_unprepare && swidget->prepared) {

				if (widget_ops[widget->id].ipc_unprepare && swidget->prepared) {

					widget_ops[widget->id].ipc_unprepare(swidget);

					swidget->prepared = false;

				}