Commit 2fcb9362 authored by SeongJae Park's avatar SeongJae Park Committed by Linus Torvalds
Browse files

mm/damon: add a tracepoint 

This commit adds a tracepoint for DAMON.  It traces the monitoring results
of each region for each aggregation interval.  Using this, DAMON can
easily integrated with tracepoints supporting tools such as perf.

Link: https://lkml.kernel.org/r/20210716081449.22187-7-sj38.park@gmail.com


Signed-off-by: default avatarSeongJae Park <sjpark@amazon.de>
Reviewed-by: default avatarLeonard Foerster <foersleo@amazon.de>
Reviewed-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: default avatarFernand Sieber <sieberf@amazon.com>
Acked-by: default avatarShakeel Butt <shakeelb@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Amit Shah <amit@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: David Rientjes <rientjes@google.com>
Cc: David Woodhouse <dwmw@amazon.com>
Cc: Fan Du <fan.du@intel.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Joe Perches <joe@perches.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Marco Elver <elver@google.com>
Cc: Markus Boehme <markubo@amazon.de>
Cc: Maximilian Heyne <mheyne@amazon.de>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3f49584b

include/trace/events/damon.h

0 → 100644
+43 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#undef TRACE_SYSTEM

#define TRACE_SYSTEM damon



#if !defined(_TRACE_DAMON_H) || defined(TRACE_HEADER_MULTI_READ)

#define _TRACE_DAMON_H



#include <linux/damon.h>

#include <linux/types.h>

#include <linux/tracepoint.h>



TRACE_EVENT(damon_aggregated,



	TP_PROTO(struct damon_target *t, struct damon_region *r,

		unsigned int nr_regions),



	TP_ARGS(t, r, nr_regions),



	TP_STRUCT__entry(

		__field(unsigned long, target_id)

		__field(unsigned int, nr_regions)

		__field(unsigned long, start)

		__field(unsigned long, end)

		__field(unsigned int, nr_accesses)

	),



	TP_fast_assign(

		__entry->target_id = t->id;

		__entry->nr_regions = nr_regions;

		__entry->start = r->ar.start;

		__entry->end = r->ar.end;

		__entry->nr_accesses = r->nr_accesses;

	),



	TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u",

			__entry->target_id, __entry->nr_regions,

			__entry->start, __entry->end, __entry->nr_accesses)

);



#endif /* _TRACE_DAMON_H */



/* This part must be outside protection */

#include <trace/define_trace.h>

mm/damon/core.c

+6 −1
Original line number Diff line number Diff line
@@ -13,6 +13,9 @@ 
#include <linux/random.h>

#include <linux/slab.h>



#define CREATE_TRACE_POINTS

#include <trace/events/damon.h>



/* Get a random number in [l, r) */

#define damon_rand(l, r) (l + prandom_u32_max(r - l))
@@ -387,10 +390,12 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) 
	damon_for_each_target(t, c) {

		struct damon_region *r;



		damon_for_each_region(r, t)

		damon_for_each_region(r, t) {

			trace_damon_aggregated(t, r, damon_nr_regions(t));

			r->nr_accesses = 0;

		}

	}

}



#define sz_damon_region(r) (r->ar.end - r->ar.start)