Commit 2f70cbf7 authored by Colin Ian King's avatar Colin Ian King Committed by Zack Rusin
Browse files

drm/vmwgfx: Fix memory allocation check and a leak of object fifo 



The allocation of fifo is lacking an allocation failure check, so
fix this by adding one.

In the case where fifo->static_buffer fails to be allocated the
error return path neglects to kfree the fifo object. Fix this by
adding in the missing kfree.

Kudos to Dan Carpenter for spotting the missing kzalloc failure
check.

Addresses-Coverity: ("Resource leak")
Fixes: 2cd80dbd ("drm/vmwgfx: Add basic support for SVGA3")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210514144930.89813-1-colin.king@canonical.com
parent 1275e417

drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c

+5 −1
Original line number Diff line number Diff line
@@ -105,10 +105,14 @@ struct vmw_fifo_state *vmw_fifo_create(struct vmw_private *dev_priv) 
		return NULL;



	fifo = kzalloc(sizeof(*fifo), GFP_KERNEL);

	if (!fifo)

		return ERR_PTR(-ENOMEM);

	fifo->static_buffer_size = VMWGFX_FIFO_STATIC_SIZE;

	fifo->static_buffer = vmalloc(fifo->static_buffer_size);

	if (unlikely(fifo->static_buffer == NULL))

	if (unlikely(fifo->static_buffer == NULL)) {

		kfree(fifo);

		return ERR_PTR(-ENOMEM);

	}



	fifo->dynamic_buffer = NULL;

	fifo->reserved_size = 0;