Commit 2f5fab1b authored by Quinn Tran's avatar Quinn Tran Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: edif: Fix clang warning 



clang warning:

  drivers/scsi/qla2xxx/qla_edif_bsg.h:93:12: warning: field remote_pid
  within 'struct app_pinfo_req' is less aligned than 'port_id_t' and is
  usually due to 'struct app_pinfo_req' being packed, which can lead to
  unaligned accesses [-Wunaligned-access]
  port_id_t remote_pid;
	        ^
  2 warnings generated.

Remove u32 field in remote_pid to silence warning.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: 7ebb336e ("scsi: qla2xxx: edif: Add start + stop bsgs")
Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 1f8f9c34

drivers/scsi/qla2xxx/qla_edif.c

+3 −1
Original line number Diff line number Diff line
@@ -967,7 +967,9 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job) 
			if (!(fcport->flags & FCF_FCSP_DEVICE))

				continue;



			tdid = app_req.remote_pid;

			tdid.b.domain = app_req.remote_pid.domain;

			tdid.b.area = app_req.remote_pid.area;

			tdid.b.al_pa = app_req.remote_pid.al_pa;



			ql_dbg(ql_dbg_edif, vha, 0x2058,

			    "APP request entry - portid=%06x.\n", tdid.b24);

drivers/scsi/qla2xxx/qla_edif_bsg.h

+14 −1
Original line number Diff line number Diff line
@@ -89,7 +89,20 @@ struct app_plogi_reply { 
struct app_pinfo_req {

	struct app_id app_info;

	uint8_t	 num_ports;

	port_id_t remote_pid;

	struct {

#ifdef __BIG_ENDIAN

		uint8_t domain;

		uint8_t area;

		uint8_t al_pa;

#elif defined(__LITTLE_ENDIAN)

		uint8_t al_pa;

		uint8_t area;

		uint8_t domain;

#else

#error "__BIG_ENDIAN or __LITTLE_ENDIAN must be defined!"

#endif

		uint8_t rsvd_1;

	} remote_pid;

	uint8_t		version;

	uint8_t		pad[VND_CMD_PAD_SIZE];

	uint8_t		reserved[VND_CMD_APP_RESERVED_SIZE];