Commit 2f3ba73a authored by Sam Ravnborg's avatar Sam Ravnborg
Browse files

drm: drop unused drm_crtc callback 



struct drm_encoder_helper_funcs included a callback
named drm_crtc.

There are no users left - so drop it.
There was one reference in drm_crtc_helper.c,
which checked if the value was not NULL.
As it was never assigned this check could be dropped.

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200215173342.GA7458@ravnborg.org
parent acce61bf

drivers/gpu/drm/drm_crtc_helper.c

+0 −4
Original line number Diff line number Diff line
@@ -244,10 +244,6 @@ drm_crtc_prepare_encoders(struct drm_device *dev) 
		/* Disable unused encoders */

		if (encoder->crtc == NULL)

			drm_encoder_disable(encoder);

		/* Disable encoders whose CRTC is about to change */

		if (encoder_funcs->get_crtc &&

		    encoder->crtc != (*encoder_funcs->get_crtc)(encoder))

			drm_encoder_disable(encoder);

	}

}

include/drm/drm_modeset_helper_vtables.h

+0 −16
Original line number Diff line number Diff line
@@ -692,22 +692,6 @@ struct drm_encoder_helper_funcs { 
				struct drm_crtc_state *crtc_state,

				struct drm_connector_state *conn_state);



	/**

	 * @get_crtc:

	 *

	 * This callback is used by the legacy CRTC helpers to work around

	 * deficiencies in its own book-keeping.

	 *

	 * Do not use, use atomic helpers instead, which get the book keeping

	 * right.

	 *

	 * FIXME:

	 *

	 * Currently only nouveau is using this, and as soon as nouveau is

	 * atomic we can ditch this hook.

	 */

	struct drm_crtc *(*get_crtc)(struct drm_encoder *encoder);



	/**

	 * @detect:

	 *