Commit 2f39f68c authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Pavel Machek
Browse files

leds: lm3532: Make error handling more robust 



It's easy to miss necessary clean up, e.g. firmware node reference counting,
during error path in ->probe(). Make it more robust by moving to a single
point of return.

Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 99be74f6

drivers/leds/leds-lm3532.c

+2 −5
Original line number Diff line number Diff line
@@ -586,7 +586,6 @@ static int lm3532_parse_node(struct lm3532_data *priv) 
		ret = fwnode_property_read_u32(child, "reg", &control_bank);

		if (ret) {

			dev_err(&priv->client->dev, "reg property missing\n");

			fwnode_handle_put(child);

			goto child_out;

		}
@@ -601,7 +600,6 @@ static int lm3532_parse_node(struct lm3532_data *priv) 
					       &led->mode);

		if (ret) {

			dev_err(&priv->client->dev, "ti,led-mode property missing\n");

			fwnode_handle_put(child);

			goto child_out;

		}
@@ -636,7 +634,6 @@ static int lm3532_parse_node(struct lm3532_data *priv) 
						    led->num_leds);

		if (ret) {

			dev_err(&priv->client->dev, "led-sources property missing\n");

			fwnode_handle_put(child);

			goto child_out;

		}
@@ -647,7 +644,6 @@ static int lm3532_parse_node(struct lm3532_data *priv) 
		if (ret) {

			dev_err(&priv->client->dev, "led register err: %d\n",

				ret);

			fwnode_handle_put(child);

			goto child_out;

		}
@@ -655,14 +651,15 @@ static int lm3532_parse_node(struct lm3532_data *priv) 
		if (ret) {

			dev_err(&priv->client->dev, "register init err: %d\n",

				ret);

			fwnode_handle_put(child);

			goto child_out;

		}



		i++;

	}

	return 0;



child_out:

	fwnode_handle_put(child);

	return ret;

}