Commit 2f308f00 authored by Johannes Berg's avatar Johannes Berg Committed by Luca Coelho
Browse files

iwlwifi: mvm: avoid FW restart while shutting down 



If the firmware crashes while we're already shutting down
the system, there isn't much we can do since the shutdown
process is continuing and we wanted to do that. Don't do
a FW restart, with the implied debug collection, in this
case.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20210802170640.43a7351ae6bd.I164d48ce4379accf76ea0637983fd946d52dc6f5@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 0eb5a554

drivers/net/wireless/intel/iwlwifi/mvm/ops.c

+8 −0
Original line number Diff line number Diff line
@@ -1466,6 +1466,14 @@ static void iwl_mvm_nic_error(struct iwl_op_mode *op_mode) 
	if (!test_bit(STATUS_TRANS_DEAD, &mvm->trans->status))

		iwl_mvm_dump_nic_error_log(mvm);



	/*

	 * If the firmware crashes while we're already considering it

	 * to be dead then don't ask for a restart, that cannot do

	 * anything useful anyway.

	 */

	if (!test_bit(IWL_MVM_STATUS_FIRMWARE_RUNNING, &mvm->status))

		return;



	iwl_mvm_nic_restart(mvm, true);

}