Commit 2efc0210 authored by xinhui pan's avatar xinhui pan Committed by Alex Deucher
Browse files

drm/radeon: Fix size overflow 



ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly

Fixes: 230c079f ("drm/ttm: make num_pages uint32_t")
Signed-off-by: default avatarxinhui pan <xinhui.pan@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 1b0b6e93

drivers/gpu/drm/radeon/radeon_ttm.c

+2 −2
Original line number Diff line number Diff line
@@ -364,7 +364,7 @@ static int radeon_ttm_tt_pin_userptr(struct ttm_bo_device *bdev, struct ttm_tt * 
	if (gtt->userflags & RADEON_GEM_USERPTR_ANONONLY) {

		/* check that we only pin down anonymous memory

		   to prevent problems with writeback */

		unsigned long end = gtt->userptr + ttm->num_pages * PAGE_SIZE;

		unsigned long end = gtt->userptr + (u64)ttm->num_pages * PAGE_SIZE;

		struct vm_area_struct *vma;

		vma = find_vma(gtt->usermm, gtt->userptr);

		if (!vma || vma->vm_file || vma->vm_end < end)
@@ -386,7 +386,7 @@ static int radeon_ttm_tt_pin_userptr(struct ttm_bo_device *bdev, struct ttm_tt * 
	} while (pinned < ttm->num_pages);



	r = sg_alloc_table_from_pages(ttm->sg, ttm->pages, ttm->num_pages, 0,

				      ttm->num_pages << PAGE_SHIFT,

				      (u64)ttm->num_pages << PAGE_SHIFT,

				      GFP_KERNEL);

	if (r)

		goto release_sg;