Commit 2edd9257 authored by Jiri Pirko's avatar Jiri Pirko Committed by Paolo Abeni
Browse files

devlink: don't allow to change net namespace for FW_ACTIVATE reload action 



The change on network namespace only makes sense during re-init reload
action. For FW activation it is not applicable. So check if user passed
an ATTR indicating network namespace change request and forbid it.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20230213115836.3404039-1-jiri@resnulli.us


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent dca5161f

net/devlink/dev.c

+6 −0
Original line number Diff line number Diff line
@@ -476,6 +476,12 @@ int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info) 
		dest_net = devlink_netns_get(skb, info);

		if (IS_ERR(dest_net))

			return PTR_ERR(dest_net);

		if (!net_eq(dest_net, devlink_net(devlink)) &&

		    action != DEVLINK_RELOAD_ACTION_DRIVER_REINIT) {

			NL_SET_ERR_MSG_MOD(info->extack,

					   "Changing namespace is only supported for reinit action");

			return -EOPNOTSUPP;

		}

	}



	err = devlink_reload(devlink, dest_net, action, limit, &actions_performed, info->extack);