Commit 2e7d4c2c authored by Arnaud Pouliquen's avatar Arnaud Pouliquen Committed by Bjorn Andersson
Browse files

remoteproc: fix kernel-doc warnings 



Fix the following warnings when documentation is built:
drivers/remoteproc/remoteproc_virtio.c:330: warning: Function parameter
or member 'id' not described in 'rproc_add_virtio_dev'
drivers/remoteproc/remoteproc_core.c:243: warning: Function parameter
or member 'name' not described in 'rproc_find_carveout_by_name'
drivers/remoteproc/remoteproc_core.c:473: warning: Function parameter
or member 'offset' not described in 'rproc_handle_vdev'
drivers/remoteproc/remoteproc_core.c:604: warning: Function parameter
or member 'offset' not described in 'rproc_handle_trace'
drivers/remoteproc/remoteproc_core.c:678: warning: Function parameter
or member 'offset' not described in 'rproc_handle_devmem'
drivers/remoteproc/remoteproc_core.c:873: warning: Function parameter
or member 'offset' not described in 'rproc_handle_carveout'
drivers/remoteproc/remoteproc_core.c:1029: warning: cannot understand function
prototype: 'rproc_handle_resource_t rproc_loading_handlers[RSC_LAST] = '
drivers/remoteproc/remoteproc_core.c:1693: warning: Function parameter
or member 'work' not described in 'rproc_crash_handler_work'

Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarArnaud Pouliquen <arnaud.pouliquen@st.com>
Link: https://lore.kernel.org/r/20200212161956.10358-1-arnaud.pouliquen@st.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent d96f2571

drivers/remoteproc/remoteproc_core.c

+8 −2
Original line number Diff line number Diff line
@@ -224,7 +224,8 @@ EXPORT_SYMBOL(rproc_da_to_va); 
/**

 * rproc_find_carveout_by_name() - lookup the carveout region by a name

 * @rproc: handle of a remote processor

 * @name,..: carveout name to find (standard printf format)

 * @name: carveout name to find (format string)

 * @...: optional parameters matching @name string

 *

 * Platform driver has the capability to register some pre-allacoted carveout

 * (physically contiguous memory regions) before rproc firmware loading and
@@ -445,6 +446,7 @@ static void rproc_rvdev_release(struct device *dev) 
 * rproc_handle_vdev() - handle a vdev fw resource

 * @rproc: the remote processor

 * @rsc: the vring resource descriptor

 * @offset: offset of the resource entry

 * @avail: size of available data (for sanity checking the image)

 *

 * This resource entry requests the host to statically register a virtio
@@ -587,6 +589,7 @@ void rproc_vdev_release(struct kref *ref) 
 * rproc_handle_trace() - handle a shared trace buffer resource

 * @rproc: the remote processor

 * @rsc: the trace resource descriptor

 * @offset: offset of the resource entry

 * @avail: size of available data (for sanity checking the image)

 *

 * In case the remote processor dumps trace logs into memory,
@@ -652,6 +655,7 @@ static int rproc_handle_trace(struct rproc *rproc, struct fw_rsc_trace *rsc, 
 * rproc_handle_devmem() - handle devmem resource entry

 * @rproc: remote processor handle

 * @rsc: the devmem resource entry

 * @offset: offset of the resource entry

 * @avail: size of available data (for sanity checking the image)

 *

 * Remote processors commonly need to access certain on-chip peripherals.
@@ -853,6 +857,7 @@ static int rproc_release_carveout(struct rproc *rproc, 
 * rproc_handle_carveout() - handle phys contig memory allocation requests

 * @rproc: rproc handle

 * @rsc: the resource entry

 * @offset: offset of the resource entry

 * @avail: size of available data (for image validation)

 *

 * This function will handle firmware requests for allocation of physically
@@ -1022,7 +1027,7 @@ rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, int len, 
}

EXPORT_SYMBOL(rproc_of_resm_mem_entry_init);



/**

/*

 * A lookup table for resource handlers. The indices are defined in

 * enum fw_resource_type.

 */
@@ -1685,6 +1690,7 @@ int rproc_trigger_recovery(struct rproc *rproc) 


/**

 * rproc_crash_handler_work() - handle a crash

 * @work: work treating the crash

 *

 * This function needs to handle everything related to a crash, like cpu

 * registers and stack dump, information to help to debug the fatal error, etc.

drivers/remoteproc/remoteproc_virtio.c

+1 −0
Original line number Diff line number Diff line
@@ -320,6 +320,7 @@ static void rproc_virtio_dev_release(struct device *dev) 
/**

 * rproc_add_virtio_dev() - register an rproc-induced virtio device

 * @rvdev: the remote vdev

 * @id: the device type identification (used to match it with a driver).

 *

 * This function registers a virtio device. This vdev's partent is

 * the rproc device.