Commit 2e5de7e0 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

mptcp: fix bit MPTCP_PUSH_PENDING tests 



The MPTCP_PUSH_PENDING define is 6 and these tests should be testing if
BIT(6) is set.

Fixes: c2e6048f ("mptcp: fix race in release_cb")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b1dd9bf6

net/mptcp/protocol.c

+2 −2
Original line number Diff line number Diff line
@@ -2968,7 +2968,7 @@ static void mptcp_release_cb(struct sock *sk) 
	for (;;) {

		flags = 0;

		if (test_and_clear_bit(MPTCP_PUSH_PENDING, &mptcp_sk(sk)->flags))

			flags |= MPTCP_PUSH_PENDING;

			flags |= BIT(MPTCP_PUSH_PENDING);

		if (!flags)

			break;
@@ -2981,7 +2981,7 @@ static void mptcp_release_cb(struct sock *sk) 
		 */



		spin_unlock_bh(&sk->sk_lock.slock);

		if (flags & MPTCP_PUSH_PENDING)

		if (flags & BIT(MPTCP_PUSH_PENDING))

			__mptcp_push_pending(sk, 0);



		cond_resched();