Commit 2e539b73 authored by Tom Rix's avatar Tom Rix Committed by Bartosz Golaszewski
Browse files

gpio: tegra186: remove unneeded loop in tegra186_gpio_init_route_mapping() 



Reviewing the j loop over num_irqs_per_bank, in the code previous
to the fixes: commit, every j was used. now only when j == 0.
If only j == 0 is used, there is no need for the loop.

Fixes: 21038680 ("gpio: tegra186: Support multiple interrupts per bank")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent eed5a3bf

drivers/gpio/gpio-tegra186.c

+18 −22
Original line number Diff line number Diff line
@@ -677,7 +677,7 @@ static const struct of_device_id tegra186_pmc_of_match[] = { 
static void tegra186_gpio_init_route_mapping(struct tegra_gpio *gpio)

{

	struct device *dev = gpio->gpio.parent;

	unsigned int i, j;

	unsigned int i;

	u32 value;



	for (i = 0; i < gpio->soc->num_ports; i++) {
@@ -699,11 +699,10 @@ static void tegra186_gpio_init_route_mapping(struct tegra_gpio *gpio) 
			 * On Tegra194 and later, each pin can be routed to one or more

			 * interrupts.

			 */

			for (j = 0; j < gpio->num_irqs_per_bank; j++) {

			dev_dbg(dev, "programming default interrupt routing for port %s\n",

				port->name);



				offset = TEGRA186_GPIO_INT_ROUTE_MAPPING(p, j);

			offset = TEGRA186_GPIO_INT_ROUTE_MAPPING(p, 0);



			/*

			 * By default we only want to route GPIO pins to IRQ 0. This works
@@ -714,15 +713,12 @@ static void tegra186_gpio_init_route_mapping(struct tegra_gpio *gpio) 
			 * to configure the interrupt routing and pass only the valid

			 * interrupts via device tree.

			 */

				if (j == 0) {

			value = readl(base + offset);

			value = BIT(port->pins) - 1;

			writel(value, base + offset);

		}

	}

}

	}

}



static unsigned int tegra186_gpio_irqs_per_bank(struct tegra_gpio *gpio)

{