Commit 2e30dd9e authored by Borislav Petkov's avatar Borislav Petkov
Browse files

x86/mtrr: Get rid of mtrr_seq_show() forward declaration 



... by moving the function up in the file.

No functional changes.

Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20191108200815.24589-1-bp@alien8.de
parent e42617b8

arch/x86/kernel/cpu/mtrr/if.c

+20 −22
Original line number Diff line number Diff line
@@ -373,28 +373,6 @@ static int mtrr_close(struct inode *ino, struct file *file) 
	return single_release(ino, file);

}



static int mtrr_seq_show(struct seq_file *seq, void *offset);



static int mtrr_open(struct inode *inode, struct file *file)

{

	if (!mtrr_if)

		return -EIO;

	if (!mtrr_if->get)

		return -ENXIO;

	return single_open(file, mtrr_seq_show, NULL);

}



static const struct file_operations mtrr_fops = {

	.owner			= THIS_MODULE,

	.open			= mtrr_open,

	.read			= seq_read,

	.llseek			= seq_lseek,

	.write			= mtrr_write,

	.unlocked_ioctl		= mtrr_ioctl,

	.compat_ioctl		= mtrr_ioctl,

	.release		= mtrr_close,

};



static int mtrr_seq_show(struct seq_file *seq, void *offset)

{

	char factor;
@@ -426,6 +404,26 @@ static int mtrr_seq_show(struct seq_file *seq, void *offset) 
	return 0;

}



static int mtrr_open(struct inode *inode, struct file *file)

{

	if (!mtrr_if)

		return -EIO;

	if (!mtrr_if->get)

		return -ENXIO;

	return single_open(file, mtrr_seq_show, NULL);

}



static const struct file_operations mtrr_fops = {

	.owner			= THIS_MODULE,

	.open			= mtrr_open,

	.read			= seq_read,

	.llseek			= seq_lseek,

	.write			= mtrr_write,

	.unlocked_ioctl		= mtrr_ioctl,

	.compat_ioctl		= mtrr_ioctl,

	.release		= mtrr_close,

};



static int __init mtrr_if_init(void)

{

	struct cpuinfo_x86 *c = &boot_cpu_data;