Commit 2e07192a authored by Peiyang Wang's avatar Peiyang Wang Committed by Hao Chen
Browse files

net: hns3: use the user's cfg after reset 

maillist inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAN3KC
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=30545e17eac1f50c5ef49644daf6af205100a965



----------------------------------------------------------------------

:Consider the followed case that the user change speed and reset the net
interface. Before the hw change speed successfully, the driver get old
old speed from hw by timer task. After reset, the previous speed is config
to hw. As a result, the new speed is configed successfully but lost after
PF reset. The followed pictured shows more dirrectly.

+------+              +----+                 +----+
| USER |              | PF |                 | HW |
+---+--+              +-+--+                 +-+--+
    |  ethtool -s 100G  |                      |
    +------------------>|   set speed 100G     |
    |                   +--------------------->|
    |                   |  set successfully    |
    |                   |<---------------------+---+
    |                   |query cfg (timer task)|   |
    |                   +--------------------->|   | handle speed
    |                   |     return 200G      |   | changing event
    |  ethtool --reset  |<---------------------+   | (100G)
    +------------------>|  cfg previous speed  |<--+
    |                   |  after reset (200G)  |
    |                   +--------------------->|
    |                   |                      +---+
    |                   |query cfg (timer task)|   |
    |                   +--------------------->|   | handle speed
    |                   |     return 100G      |   | changing event
    |                   |<---------------------+   | (200G)
    |                   |                      |<--+
    |                   |query cfg (timer task)|
    |                   +--------------------->|
    |                   |     return 200G      |
    |                   |<---------------------+
    |                   |                      |
    v                   v                      v

This patch save new speed if hw change speed successfully, which will be
used after reset successfully.

Fixes: 46a3df9f ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: default avatarPeiyang Wang <wangpeiyang1@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ee32a2e6

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+17 −7
Original line number Diff line number Diff line
@@ -2754,8 +2754,16 @@ static int hclge_cfg_mac_speed_dup_h(struct hnae3_handle *handle, int speed, 
{

	struct hclge_vport *vport = hclge_get_vport(handle);

	struct hclge_dev *hdev = vport->back;

	int ret;



	ret = hclge_cfg_mac_speed_dup(hdev, speed, duplex);

	if (ret)

		return ret;



	return hclge_cfg_mac_speed_dup(hdev, speed, duplex);

	hdev->hw.mac.req_speed = speed;

	hdev->hw.mac.req_duplex = duplex;



	return 0;

}



static int hclge_set_autoneg_en(struct hclge_dev *hdev, bool enable)
@@ -2923,14 +2931,16 @@ static int hclge_mac_init(struct hclge_dev *hdev) 
	if (!test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state))

		hdev->hw.mac.duplex = HCLGE_MAC_FULL;



	ret = hclge_cfg_mac_speed_dup_hw(hdev, hdev->hw.mac.speed,

					 hdev->hw.mac.duplex,

					 hdev->hw.mac.lane_num);

	if (hdev->hw.mac.support_autoneg) {

		ret = hclge_set_autoneg_en(hdev, hdev->hw.mac.autoneg);

		if (ret)

			return ret;

	}



	if (hdev->hw.mac.support_autoneg) {

		ret = hclge_set_autoneg_en(hdev, hdev->hw.mac.autoneg);

	if (!hdev->hw.mac.autoneg) {

		ret = hclge_cfg_mac_speed_dup_hw(hdev, hdev->hw.mac.req_speed,

						 hdev->hw.mac.req_duplex,

						 hdev->hw.mac.lane_num);

		if (ret)

			return ret;

	}

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c

+3 −0
Original line number Diff line number Diff line
@@ -191,6 +191,9 @@ static void hclge_mac_adjust_link(struct net_device *netdev) 
	if (ret)

		netdev_err(netdev, "failed to adjust link.\n");



	hdev->hw.mac.req_speed = (u32)speed;

	hdev->hw.mac.req_duplex = (u8)duplex;



	ret = hclge_cfg_flowctrl(hdev);

	if (ret)

		netdev_err(netdev, "failed to configure flow control.\n");