Commit 2dd5bed5 authored by Clemens Ladisch's avatar Clemens Ladisch Committed by Stefan Richter
Browse files

firewire: ohci: optimize iso context checks in the interrupt handler 



When the isochRx/isochTx bit is clear, we do not need to read the
corresponding iso interrupt event register.

Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 5b06db16

drivers/firewire/ohci.c

+19 −13
Original line number Diff line number Diff line
@@ -1813,23 +1813,29 @@ static irqreturn_t irq_handler(int irq, void *data) 
	if (event & OHCI1394_respTxComplete)

		tasklet_schedule(&ohci->at_response_ctx.tasklet);



	if (event & OHCI1394_isochRx) {

		iso_event = reg_read(ohci, OHCI1394_IsoRecvIntEventClear);

		reg_write(ohci, OHCI1394_IsoRecvIntEventClear, iso_event);



		while (iso_event) {

			i = ffs(iso_event) - 1;

		tasklet_schedule(&ohci->ir_context_list[i].context.tasklet);

			tasklet_schedule(

				&ohci->ir_context_list[i].context.tasklet);

			iso_event &= ~(1 << i);

		}

	}



	if (event & OHCI1394_isochTx) {

		iso_event = reg_read(ohci, OHCI1394_IsoXmitIntEventClear);

		reg_write(ohci, OHCI1394_IsoXmitIntEventClear, iso_event);



		while (iso_event) {

			i = ffs(iso_event) - 1;

		tasklet_schedule(&ohci->it_context_list[i].context.tasklet);

			tasklet_schedule(

				&ohci->it_context_list[i].context.tasklet);

			iso_event &= ~(1 << i);

		}

	}



	if (unlikely(event & OHCI1394_regAccessFail))

		fw_error("Register access failure - "