Commit 2dd0df84 authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

cpufreq: Drop cpufreq_table_validate_and_show() 



This isn't used anymore. Remove the helper and update documentation
accordingly.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent d983af98

Documentation/cpu-freq/core.txt

+5 −7
Original line number Diff line number Diff line
@@ -97,12 +97,10 @@ flags - flags of the cpufreq driver 
==================================================================

For details about OPP, see Documentation/power/opp.txt



dev_pm_opp_init_cpufreq_table - cpufreq framework typically is initialized with

	cpufreq_table_validate_and_show() which is provided with the list of

	frequencies that are available for operation. This function provides

	a ready to use conversion routine to translate the OPP layer's internal

	information about the available frequencies into a format readily

	providable to cpufreq.

dev_pm_opp_init_cpufreq_table -

	This function provides a ready to use conversion routine to translate

	the OPP layer's internal information about the available frequencies

	into a format readily providable to cpufreq.



	WARNING: Do not use this function in interrupt context.
@@ -112,7 +110,7 @@ dev_pm_opp_init_cpufreq_table - cpufreq framework typically is initialized with 
		/* Do things */

		r = dev_pm_opp_init_cpufreq_table(dev, &freq_table);

		if (!r)

			cpufreq_table_validate_and_show(policy, freq_table);

			policy->freq_table = freq_table;

		/* Do other things */

	 }

Documentation/cpu-freq/cpu-drivers.txt

+2 −4
Original line number Diff line number Diff line
@@ -259,10 +259,8 @@ CPUFREQ_ENTRY_INVALID. The entries don't need to be in sorted in any 
particular order, but if they are cpufreq core will do DVFS a bit

quickly for them as search for best match is faster.



By calling cpufreq_table_validate_and_show(), the cpuinfo.min_freq and

cpuinfo.max_freq values are detected, and policy->min and policy->max

are set to the same values. This is helpful for the per-CPU

initialization stage.

The cpufreq table is verified automatically by the core if the policy contains a

valid pointer in its policy->freq_table field.



cpufreq_frequency_table_verify() assures that at least one valid

frequency is within policy->min and policy->max, and all other criteria

drivers/cpufreq/freq_table.c

+0 −14
Original line number Diff line number Diff line
@@ -352,20 +352,6 @@ static int set_freq_table_sorted(struct cpufreq_policy *policy) 
	return 0;

}



int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,

				      struct cpufreq_frequency_table *table)

{

	int ret;



	ret = cpufreq_frequency_table_cpuinfo(policy, table);

	if (ret)

		return ret;



	policy->freq_table = table;

	return 0;

}

EXPORT_SYMBOL_GPL(cpufreq_table_validate_and_show);



int cpufreq_table_validate_and_sort(struct cpufreq_policy *policy)

{

	int ret;

include/linux/cpufreq.h

+0 −2
Original line number Diff line number Diff line
@@ -960,8 +960,6 @@ extern void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq, 
extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs;

extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs;

extern struct freq_attr *cpufreq_generic_attr[];

int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,

				      struct cpufreq_frequency_table *table);

int cpufreq_table_validate_and_sort(struct cpufreq_policy *policy);



unsigned int cpufreq_generic_get(unsigned int cpu);