Commit 2db96217 authored by Ye Bin's avatar Ye Bin Committed by Jens Axboe
Browse files

blktrace: remove unnessary stop block trace in 'blk_trace_shutdown' 



As previous commit, 'blk_trace_cleanup' will stop block trace if
block trace's state is 'Blktrace_running'.
So remove unnessary stop block trace in 'blk_trace_shutdown'.

Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20221019033602.752383-4-yebin@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent dcd1a59c

kernel/trace/blktrace.c

+1 −3
Original line number Diff line number Diff line
@@ -776,11 +776,9 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg) 
void blk_trace_shutdown(struct request_queue *q)

{

	if (rcu_dereference_protected(q->blk_trace,

				      lockdep_is_held(&q->debugfs_mutex))) {

		__blk_trace_startstop(q, 0);

				      lockdep_is_held(&q->debugfs_mutex)))

		__blk_trace_remove(q);

}

}



#ifdef CONFIG_BLK_CGROUP

static u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)