Commit 2d94b20b authored by Brett Mastbergen's avatar Brett Mastbergen Committed by Pablo Neira Ayuso
Browse files

netfilter: nft_ct: Remove confirmation check for NFT_CT_ID 



Since commit 656c8e9c ("netfilter: conntrack: Use consistent ct id
hash calculation") the ct id will not change from initialization to
confirmation.  Removing the confirmation check allows for things like
adding an element to a 'typeof ct id' set in prerouting upon reception
of the first packet of a new connection, and then being able to
reference that set consistently both before and after the connection
is confirmed.

Fixes: 656c8e9c ("netfilter: conntrack: Use consistent ct id hash calculation")
Signed-off-by: default avatarBrett Mastbergen <brett.mastbergen@gmail.com>
Acked-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 42f1c271

net/netfilter/nft_ct.c

+0 −2
Original line number Diff line number Diff line
@@ -177,8 +177,6 @@ static void nft_ct_get_eval(const struct nft_expr *expr, 
	}

#endif

	case NFT_CT_ID:

		if (!nf_ct_is_confirmed(ct))

			goto err;

		*dest = nf_ct_get_id(ct);

		return;

	default: