Commit 2d830f7a authored by Maxime Chevallier's avatar Maxime Chevallier Committed by Jakub Kicinski
Browse files

net: altera-tse: Initialize local structs before using it 



The regmap_config and mdio_regmap_config objects needs to be zeroed before
using them. This will cause spurious errors at probe time as config->pad_bits
is containing random uninitialized data.

Fixes: db48abba ("net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx")
Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6878eb59

drivers/net/ethernet/altera/altera_tse_main.c

+2 −0
Original line number Diff line number Diff line
@@ -1255,6 +1255,8 @@ static int altera_tse_probe(struct platform_device *pdev) 
	if (ret)

		goto err_free_netdev;



	memset(&pcs_regmap_cfg, 0, sizeof(pcs_regmap_cfg));

	memset(&mrc, 0, sizeof(mrc));

	/* SGMII PCS address space. The location can vary depending on how the

	 * IP is integrated. We can have a resource dedicated to it at a specific

	 * address space, but if it's not the case, we fallback to the mdiophy0