Commit 2d74ec97 authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: add low bound validation to FSCTL_SET_ZERO_DATA 



Smatch static checker warning:
 fs/ksmbd/smb2pdu.c:7759 smb2_ioctl()
 warn: no lower bound on 'off'

Fix unexpected result that could caused from negative off and bfz.

Fixes: b5e5f9df ("ksmbd: check invalid FileOffset and BeyondFinalZero in FSCTL_ZERO_DATA")
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Reviewed-by: default avatarSergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 728f14c7

fs/ksmbd/smb2pdu.c

+1 −1
Original line number Diff line number Diff line
@@ -7755,7 +7755,7 @@ int smb2_ioctl(struct ksmbd_work *work) 


		off = le64_to_cpu(zero_data->FileOffset);

		bfz = le64_to_cpu(zero_data->BeyondFinalZero);

		if (off > bfz) {

		if (off < 0 || bfz < 0 || off > bfz) {

			ret = -EINVAL;

			goto out;

		}